Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added invite implementation #708

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

0xNilesh
Copy link
Member

No description provided.

@0xNilesh 0xNilesh requested a review from arn4b September 13, 2023 08:55
@github-actions
Copy link

In the file packages/restapi/src/lib/spaceV2/SpaceV2.ts:

  1. At line 106, there is a missing closing brace for the removePeer method. Add a closing brace (}) after the console.error statement.

  2. At line 112, there is a missing closing parenthesis for the getPeerConnection method. Add a closing parenthesis ()) after the peerId parameter.

  3. At line 117, there is a missing closing parenthesis for the setPeerConnection method. Add a closing parenthesis ()) after the peerConnection parameter.

  4. At line 122, there is a missing closing parenthesis for the getConnectedPeerIds method. Add a closing parenthesis ()) after the closing bracket (]).

  5. At line 138 and line 152, there are comments with incorrect syntax. Remove the asterisk (*) at the beginning of the lines.

  6. At line 158, there is a missing closing parenthesis for the disconnect method. Add a closing parenthesis ()) after the options parameter.

  7. At line 166, there is a missing closing parenthesis for the request method. Add a closing parenthesis ()) after the options parameter.

  8. At line 173, there is an incorrect comment syntax. Replace /* with //.

  9. At line 175, there is an incorrect comment syntax. Replace /* with //.

  10. At line 182, there is an incorrect comment syntax. Replace * with //.

  11. At line 184, there is an incorrect comment syntax. Replace * with //.

  12. At line 188, there is an incorrect comment syntax. Replace * with //.

  13. At line 190, there is an incorrect comment syntax. Replace * with //.

  14. At line 196, there is an incorrect comment syntax. Replace * with //.

  15. At line 198, there is an incorrect comment syntax. Replace * with //.

  16. At line 204, there is an incorrect comment syntax. Replace * with //.

  17. At line 206, there is an incorrect comment syntax. Replace * with //.

  18. At line 214, there is an incorrect comment syntax. Replace * with //.

  19. At line 230, there is an incorrect comment syntax. Replace * with //.

  20. At line 234, there are extra empty lines. Remove the empty lines.

  21. At line 236, there are extra empty lines. Remove the empty lines.

  22. At line 23 of the file packages/restapi/src/lib/spaceV2/helpers/sendSpaceNotification.ts, the import statement for sendNotification is missing the module specifier. Add './sendNotification' as the module specifier.

  23. At line 26 of the file packages/restapi/src/lib/spaceV2/helpers/sendSpaceNotification.ts, there is an extra semicolon (;) after the closing parenthesis of the CallDetailsType interface. Remove the extra semicolon.

  24. At line 85 of the file packages/restapi/src/lib/spaceV2/types/index.ts, there is an incorrect import statement for SPACE_REQUEST_TYPE. Replace import { SPACE_REQUEST_TYPE } from "../../payloads"; with import { SPACE_REQUEST_TYPE } from "../../payloads/constants";.

All looks good.

@github-actions
Copy link

In the SpaceV2.ts file:

  1. In the initSpaceInfo object, the property inviteeDetails should have type Record<string, unknown> instead of an empty object {}.

  2. In the addPeer method, there is a missing closing brace } after the console.error statement.

  3. In the removePeer method, there is a missing closing brace } after the console.error statement.

  4. In the setPeerConnection method, there is a missing closing brace } after the peerConnections.set statement.

  5. In the connect method, the opening comment /** is missing the closing comment */.

  6. In the disconnect method, the opening comment /** is missing the closing comment */.

  7. In the request method, the opening comment /** is missing the closing comment */.

  8. In the invite method, the opening comment /** is missing the closing comment */.

In the sendSpaceNotification.ts file:

  1. The interface UserInfoType is missing a closing brace }.

  2. The function sendSpaceNotification is missing a closing brace }.

It is also recommended to refactor the code to improve readability and organization.

packages/restapi/src/lib/spaceV2/SpaceV2.ts Outdated Show resolved Hide resolved
packages/restapi/src/lib/spaceV2/inviteToJoin.ts Outdated Show resolved Hide resolved
packages/restapi/src/lib/spaceV2/inviteToJoin.ts Outdated Show resolved Hide resolved
packages/restapi/src/lib/spaceV2/inviteToJoin.ts Outdated Show resolved Hide resolved
packages/restapi/src/lib/spaceV2/types/index.ts Outdated Show resolved Hide resolved
@0xNilesh 0xNilesh merged commit da2b11b into feat/space-v2 Sep 14, 2023
1 check passed
@github-actions
Copy link

In the file packages/restapi/src/lib/spaceV2/SpaceV2.ts:

  1. There is a typo on line 81, "initSpaceInfo" should be "initSpaceV2Data".
  2. There is a missing closing brace on line 112. Add a closing brace after the console.error statement.
  3. There is a missing closing brace on line 139. Add a closing brace after the console.error statement.
  4. There is a missing closing brace on line 144. Add a closing brace after the getPeerConnection function.
  5. There is a missing closing brace on line 151. Add a closing brace after the setPeerConnection function.
  6. There is a missing closing brace on line 159. Add a closing brace after the getConnectedPeerIds function.
  7. There is a missing closing brace on line 167. Add a closing brace after the connect function.
  8. There is a missing closing brace on line 178. Add a closing brace after the disconnect function.
  9. There is a missing closing brace on line 189. Add a closing brace after the request function.
  10. There is a missing closing brace on line 201. Add a closing brace after the invite function.

In the file packages/restapi/src/lib/spaceV2/helpers/sendSpaceNotification.ts:

  1. There is a missing export statement for the UserInfoType interface. Add "export" before the interface declaration.

All looks good in the file packages/restapi/src/lib/types/index.ts.

@0xNilesh 0xNilesh deleted the refactor/add-invite branch September 14, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants