Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✏️ [Documentation/Readme Enhancement] - Fixes typo in contributing.md #942

Closed
lazyfuhrer opened this issue Dec 19, 2023 · 1 comment
Closed

✏️ [Documentation/Readme Enhancement] - Fixes typo in contributing.md #942

lazyfuhrer opened this issue Dec 19, 2023 · 1 comment
Assignees
@lazyfuhrer
Labels
documentation Improvements or additions to documentation
Milestone
Push Optimisation...

Comments

@lazyfuhrer
Copy link
Contributor

Expected Behaviour

In contributing file the correct URL for cloning should be ".../push-sdk.git" . Also the file name should be in uppercase to maintain the standard convention.

Current Behaviour

Currently it's ".../sdk.git"

Steps to Reproduce

1. Go to 'contributing.md' file
@lazyfuhrer lazyfuhrer added the documentation Improvements or additions to documentation label Dec 19, 2023
@lazyfuhrer lazyfuhrer mentioned this issue Dec 19, 2023
Merged
5 tasks
@Aman035 Aman035 added this to the Push SDK V1.6 milestone Dec 20, 2023
@Aman035
Copy link
Member

Aman035 commented Dec 20, 2023

#943 fixes this

@Aman035 Aman035 closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazyfuhrer lazyfuhrer

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Push Optimisations V1.6
Development

No branches or pull requests
2 participants
@Aman035 @lazyfuhrer