Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - Push video example app RPC not working & bug in recurring call #849

Closed
madhur-push opened this issue Nov 16, 2023 · 0 comments · Fixed by #850
Closed

🐛 [BUG] - Push video example app RPC not working & bug in recurring call #849

madhur-push opened this issue Nov 16, 2023 · 0 comments · Fixed by #850
Assignees
@madhur-push
Labels
bug Something isn't working

Comments

@madhur-push
Copy link
Contributor

Expected Behaviour

  1. RPC should work fine on the example app
  2. Recurring calls should work fine

Current Behaviour

  1. The RPC used in the push video example app is not working, need to be replaced with a different RPC.
  2. Bug in Video SDK where upon recurring calls the state wasnt getting cleared properly on end call which fails the future calls.

Reproduction steps

1. Start the next js example app
2. Try video calling an address
3. You'll see error showing failed RPC request

Screenshots

No response

Relevant Logs

No response

Dapp Env

Prod (app.push.org), Staging (staging.push.org), Dev (dev.push.org)

Browsers

Firefox, Chrome, Safari, Microsoft Edge, Opera
@madhur-push madhur-push added the bug Something isn't working label Nov 16, 2023
@madhur-push madhur-push self-assigned this Nov 16, 2023
@madhur-push madhur-push linked a pull request Nov 16, 2023 that will close this issue
fix(video): fix recurring video calls bug, rpc in example app #850
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhur-push madhur-push

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(video): fix recurring video calls bug, rpc in example app push-protocol/push-sdk
1 participant
@madhur-push