Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONSTANTS and INTERFACES in uiweb #1057

Open
HarshRajat opened this issue Jan 23, 2024 — with Slack · 0 comments
Open

Create CONSTANTS and INTERFACES in uiweb #1057

HarshRajat opened this issue Jan 23, 2024 — with Slack · 0 comments
Assignees
Labels
enhancement New feature or request frontend Frontend related

Comments

Copy link
Contributor

Rationale: currently, constants are passed as strings and interfaces are not defined which leads to issues.

Learning from restapi, we need to create CONSTANTS that will house different constants, for example CONSTANTS.CHAT.CHATPREVIEWLIST.NAME for more intiutive understanding

Same with interfaces, each interface should have an 'I' prefixed and should also be available from INTERFACES. For example: INTERFACES.CHAT.CHATPREVIEWLIST.IChatPreviewProps, etc

  • First step should be notion page to ensure all team members agree on it.
@HarshRajat HarshRajat added enhancement New feature or request frontend Frontend related labels Jan 23, 2024 — with Slack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Frontend related
Projects
None yet
Development

No branches or pull requests

2 participants