Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change RPC Serivce fn calling for client #1

Open
Aman035 opened this issue Sep 20, 2024 · 0 comments
Open

Change RPC Serivce fn calling for client #1

Aman035 opened this issue Sep 20, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Aman035
Copy link
Member

Aman035 commented Sep 20, 2024

The RPC call fn names should not have RpcService. in the naming.

  • RpcService.getBlocks should be push_getBlocks
  • RpcService.getBlockByHash should be push_getBlockByHash

Similarly for Tx RPC calls
@Aman035 Aman035 added enhancement New feature or request good first issue Good for newcomers labels Sep 20, 2024
@Aman035 Aman035 changed the title Change RPC Serivce calling for client Change RPC Serivce fn calling for client Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Aman035