Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmimalloc-sys: Differences between version on crates.io and in repo version (0.1.35) #109

Open
VorpalBlade opened this issue Apr 1, 2024 · 1 comment

Comments

@VorpalBlade
Copy link

Using cargo-goggles I discovered that libmimalloc-sys has differences between the version on crates.io and the version in the repo at the tag v0.1.35:

  • extended.rs differs (more code in repo)
  • c_src differs significantly (different version of bundled mimalloc!)
  • Declared version in Cargo.toml differs

The changes don't seem malicious (and I would assume this is an honest mistake with placing the tag at the wrong commit), but they are somewhat concerning given the recent xz backdoor. I would like an explanation of what is going on here.

@octavonce
Copy link
Collaborator

I didn't run cargo goggles but at first glance this seems to match this.

However, I see that v0.1.31 libmimalloc-sys is yanked for some reason I cannot remember now. Which means it would use a later version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants