Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace: fseq_fpu_yield identical to fseq_yield #110

Open
colluca opened this issue Mar 1, 2024 · 0 comments
Open

trace: fseq_fpu_yield identical to fseq_yield #110

colluca opened this issue Mar 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@colluca
Copy link
Collaborator

colluca commented Mar 1, 2024

Bug description

fseq_fpu_yield is currently calculated as (fpss_fpu_issues / snitch_fseq_offloads) / fpss_fpu_rel_issues:

'fseq_fpu_yield':
safe_div(
safe_div(seg['fpss_fpu_issues'], seg['snitch_fseq_offloads']),
fpss_fpu_rel_issues),

fpss_fpu_rel_issues is in turn calculated as fpss_fpu_issues / fpss_issues:

fpss_fpu_rel_issues = safe_div(seg['fpss_fpu_issues'],
seg['fpss_issues'])

It follows that fseq_fpu_yield = fpss_issues / snitch_fseq_offloads, which equals fseq_yield by definition:

'fseq_yield':
safe_div(seg['fpss_issues'], seg['snitch_fseq_offloads']),

Solution

I believe the original intent was for fseq_fpu_yield to represent the FREP yield related to FPU proper instructions only. Then we could simply calculate fseq_fpu_yield = fpss_fpu_issues / snitch_fseq_offloads. Perhaps even better, we would rectify snitch_fseq_offloads to count only instructions destined to the FPU proper.

I'm not sure of the usefulness of this metric altogether, so perhaps we could also just remove the duplicate fseq_fpu_yield.

@colluca colluca added the bug Something isn't working label Mar 1, 2024
@colluca colluca self-assigned this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant