CONTRIBUTING.md

Contribution Guide

We are happy to accept pull requests and issues from any contributors. Please note that we try to maintain a consistent quality standard. For a quick overview please find some of the most important points below.

Quick Overview

• Keep a clean commit history. This means no merge commits, and no long series of "fixup" patches (rebase or squash as appropriate). Structure work as a series of logically ordered, atomic patches. git rebase -i is your friend.
• Changes should only be made via pull request, with review. A pull request will be committed by a "committer" (an account listed in CODEOWNERS) once it has had an explicit positive review.
• Make sure you update the CHANGELOG when submitting a MR.
• When creating your first MR, enter your name in the CONTRIBUTORS list in alphabetical order.
• When changes are restricted to a specific area, you are recommended to add a tag to the beginning of the first line of the commit message in square brackets e.g., "[snitch] Fix bug #157".
• Do not force push. After rebasing, use --force-with-lease instead.
• Do not attempt to commit code with a non-Apache (or Solderpad for hardware) license without discussing first.
• If a relevant bug or tracking issue exists, reference it in the pull request and commits.

Git Considerations

• Separate subject from body with a blank line
• Limit the subject line to 72 characters
• Capitalize the subject line
• Do not end the subject line with a period
• Use the imperative mood in the subject line
• Use the body to explain what and why vs. how

For further information please see the excellent guide by Chris Beams.

Code Style

Consistent code style is important. We try to follow existing style conventions as much as possible:

• For RTL we use lowRISC's SystemVerilog style guidelines.
• For C/C++ we follow LLVM's style guide, pleas note the clang-format in the projects root.
• For Python code we follow the official pep8 style guide.
• For yaml files (such as the Bender.yml) we format using ymlfmt. Unfortunately, we do not know whether an official style guide exists.
• Use EditorConfig to format all files correctly.

Please make sure that any code you submit is adhering to the correct standard.