Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dependency conflict warning wrong #189

Open
Smephite opened this issue Dec 6, 2024 · 0 comments
Open

Bug: Dependency conflict warning wrong #189

Smephite opened this issue Dec 6, 2024 · 0 comments

Comments

@Smephite
Copy link

Smephite commented Dec 6, 2024

Setup

Having the following dependency chain:
Drawing1

A clear dependency conflict exists as when flattening the dependency tree two different versions of dep2 are depended on (1.0.0 and 1.0.1).

Note: dep1 is defined by revision whereas the other dependencies are defined by version.

What happens

Bender correctly identifies this dependency conflict but displays an unhelpful message as the version is displayed incorrectly

Requirement `master` conflicts with other requirements on dependency `dep2`.

- package `top` requires `=1.0.1`
- package `dep1` requires `master`

To resolve this conflict manually, select a revision for `dep2` among:
0) `=1.0.1`
1) `master`

i.e. the version of dep2 as required by dep1 is =1.0.0 and not master.

What is expected

Bender should display the correction version:

Requirement `=1.0.0` conflicts with other requirements on dependency `dep2`.

- package `top` requires `=1.0.1`
- package `dep1` requires `=1.0.0`

To resolve this conflict manually, select a revision for `dep2` among:
0) `=1.0.1`
1) `=1.0.0`

Additional information

Bender correctly displays the dependency conflict message when using a version tag for dep1 instead of the revision tag.

@Smephite Smephite changed the title Dependency conflict warning wrong Bug: Dependency conflict warning wrong Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant