From e5bb136f80708b261a3d69b9c41c31ecd3bf37ed Mon Sep 17 00:00:00 2001
From: Sean Warren <seanwarren77@gmail.com>
Date: Fri, 20 Dec 2024 09:56:05 -0500
Subject: [PATCH 1/3] Updated text for shopping cart delivery note

Co-authored-by: Robert-Anthony Lee-Faison <leefaisonr@users.noreply.github.com>
---
 app/javascript/components/RequestCart.vue | 2 +-
 app/javascript/test/requestCart.spec.js   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/javascript/components/RequestCart.vue b/app/javascript/components/RequestCart.vue
index 7b340807..9d4a4ced 100644
--- a/app/javascript/components/RequestCart.vue
+++ b/app/javascript/components/RequestCart.vue
@@ -87,7 +87,7 @@
             <tr v-else-if="item.location && item.location.label" class="request__location">
               <td colspan="4">
                 <geo-icon></geo-icon>
-                View this item at the <template v-if="item.location.url"><a
+                This item can be viewed in person <template v-if="item.location.url"><a
                   :href="item.location.url" target="_blank">{{ item.location.label
                   }}</a></template><template v-else>{{ item.location.label }}</template>
               </td>
diff --git a/app/javascript/test/requestCart.spec.js b/app/javascript/test/requestCart.spec.js
index 5e77826f..efbe3a6c 100644
--- a/app/javascript/test/requestCart.spec.js
+++ b/app/javascript/test/requestCart.spec.js
@@ -48,7 +48,7 @@ describe('RequestCart.vue', () => {
     const notes = container.querySelector('.request__location-notes')
     expect(notes.textContent).toMatch("It's far away")
     const locationInfo = container.querySelector('.request__location')
-    expect(locationInfo.textContent).toMatch('View this item at the Firestone Library')
+    expect(locationInfo.textContent).toMatch('This item can be viewed in person Firestone Library')
     expect(locationInfo.querySelector('a').attributes.href.value).toBe('https://example.com')
   })
   test('Rendering locations with no url', async () => {
@@ -92,7 +92,7 @@ describe('RequestCart.vue', () => {
     const notes = container.querySelector('.request__location-notes')
     expect(notes.textContent).toMatch("It's far away")
     const locationInfo = container.querySelector('.request__location')
-    expect(locationInfo.textContent).toMatch('View this item at the Firestone Library')
+    expect(locationInfo.textContent).toMatch('This item can be viewed in person Firestone Library')
     expect(locationInfo.querySelector('a')).toBe(null)
   })
   test('Submitting cart', async () => {

From 46367a2466d6cedf890d1aeb3c7a89b35df51b3d Mon Sep 17 00:00:00 2001
From: Sean Warren <seanwarren77@gmail.com>
Date: Fri, 20 Dec 2024 14:06:56 -0500
Subject: [PATCH 2/3] Changed text and removed Manuscript from Mudd Library in
 the request cart

Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
---
 app/javascript/components/RequestCart.vue | 6 +++---
 app/javascript/test/requestCart.spec.js   | 8 ++++----
 spec/features/catalog_view_spec.rb        | 2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/javascript/components/RequestCart.vue b/app/javascript/components/RequestCart.vue
index 9d4a4ced..eb02dc09 100644
--- a/app/javascript/components/RequestCart.vue
+++ b/app/javascript/components/RequestCart.vue
@@ -87,9 +87,9 @@
             <tr v-else-if="item.location && item.location.label" class="request__location">
               <td colspan="4">
                 <geo-icon></geo-icon>
-                This item can be viewed in person <template v-if="item.location.url"><a
-                  :href="item.location.url" target="_blank">{{ item.location.label
-                  }}</a></template><template v-else>{{ item.location.label }}</template>
+                This item can be viewed in person at <template v-if="item.location.url"><a
+                  :href="item.location.url" target="_blank">{{ item.location.label.replace("Manuscript ", "")
+                  }}</a></template><template v-else>{{ item.location.label.replace("Manuscript ", "") }}</template>
               </td>
             </tr>
 
diff --git a/app/javascript/test/requestCart.spec.js b/app/javascript/test/requestCart.spec.js
index efbe3a6c..6ee2a58e 100644
--- a/app/javascript/test/requestCart.spec.js
+++ b/app/javascript/test/requestCart.spec.js
@@ -20,7 +20,7 @@ describe('RequestCart.vue', () => {
               },
               location: {
                 notes: "It's far away",
-                label: 'Firestone Library',
+                label: 'Mudd Manuscript Library',
                 url: 'https://example.com'
               }
             }],
@@ -48,7 +48,7 @@ describe('RequestCart.vue', () => {
     const notes = container.querySelector('.request__location-notes')
     expect(notes.textContent).toMatch("It's far away")
     const locationInfo = container.querySelector('.request__location')
-    expect(locationInfo.textContent).toMatch('This item can be viewed in person Firestone Library')
+    expect(locationInfo.textContent).toMatch('This item can be viewed in person at Mudd Library')
     expect(locationInfo.querySelector('a').attributes.href.value).toBe('https://example.com')
   })
   test('Rendering locations with no url', async () => {
@@ -65,7 +65,7 @@ describe('RequestCart.vue', () => {
               },
               location: {
                 notes: "It's far away",
-                label: 'Firestone Library',
+                label: 'Mudd Manuscript Library',
                 url: null
               }
             }],
@@ -92,7 +92,7 @@ describe('RequestCart.vue', () => {
     const notes = container.querySelector('.request__location-notes')
     expect(notes.textContent).toMatch("It's far away")
     const locationInfo = container.querySelector('.request__location')
-    expect(locationInfo.textContent).toMatch('This item can be viewed in person Firestone Library')
+    expect(locationInfo.textContent).toMatch('This item can be viewed in person at Mudd Library')
     expect(locationInfo.querySelector('a')).toBe(null)
   })
   test('Submitting cart', async () => {
diff --git a/spec/features/catalog_view_spec.rb b/spec/features/catalog_view_spec.rb
index 578d1f4e..a3d9a1c5 100644
--- a/spec/features/catalog_view_spec.rb
+++ b/spec/features/catalog_view_spec.rb
@@ -69,7 +69,7 @@
         expect(page).to have_selector "td", text: /MC148_c00002/
         expect(page).to have_selector "td", text: /Box 1/
         expect(page).to have_selector "button[type='submit']", text: /Request 1 Item/
-        expect(page).to have_selector ".request__location", text: /View this item at the/
+        expect(page).to have_selector ".request__location", text: /This item can be viewed in person/
 
         # Click the remove item button
         find("#item-MC148_c00002 > td > button").click

From 1f1f17aacb1f7f255737a0af3ce1f463f577256e Mon Sep 17 00:00:00 2001
From: Sean Warren <seanwarren77@gmail.com>
Date: Fri, 20 Dec 2024 14:23:34 -0500
Subject: [PATCH 3/3] Added a . to the end of the line

Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
---
 app/javascript/components/RequestCart.vue | 2 +-
 app/javascript/test/requestCart.spec.js   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/javascript/components/RequestCart.vue b/app/javascript/components/RequestCart.vue
index eb02dc09..5abfe39d 100644
--- a/app/javascript/components/RequestCart.vue
+++ b/app/javascript/components/RequestCart.vue
@@ -89,7 +89,7 @@
                 <geo-icon></geo-icon>
                 This item can be viewed in person at <template v-if="item.location.url"><a
                   :href="item.location.url" target="_blank">{{ item.location.label.replace("Manuscript ", "")
-                  }}</a></template><template v-else>{{ item.location.label.replace("Manuscript ", "") }}</template>
+                  }}</a></template><template v-else>{{ item.location.label.replace("Manuscript ", "") }}</template>.
               </td>
             </tr>
 
diff --git a/app/javascript/test/requestCart.spec.js b/app/javascript/test/requestCart.spec.js
index 6ee2a58e..a93242c5 100644
--- a/app/javascript/test/requestCart.spec.js
+++ b/app/javascript/test/requestCart.spec.js
@@ -48,7 +48,7 @@ describe('RequestCart.vue', () => {
     const notes = container.querySelector('.request__location-notes')
     expect(notes.textContent).toMatch("It's far away")
     const locationInfo = container.querySelector('.request__location')
-    expect(locationInfo.textContent).toMatch('This item can be viewed in person at Mudd Library')
+    expect(locationInfo.textContent).toMatch('This item can be viewed in person at Mudd Library.')
     expect(locationInfo.querySelector('a').attributes.href.value).toBe('https://example.com')
   })
   test('Rendering locations with no url', async () => {
@@ -92,7 +92,7 @@ describe('RequestCart.vue', () => {
     const notes = container.querySelector('.request__location-notes')
     expect(notes.textContent).toMatch("It's far away")
     const locationInfo = container.querySelector('.request__location')
-    expect(locationInfo.textContent).toMatch('This item can be viewed in person at Mudd Library')
+    expect(locationInfo.textContent).toMatch('This item can be viewed in person at Mudd Library.')
     expect(locationInfo.querySelector('a')).toBe(null)
   })
   test('Submitting cart', async () => {