Merge pull request #17 from ezhlobo/fix_click_on_wp

Fix preventing default behavior of events in windows phone
pukhalski · Jan 21, 2015 · da233a5 · da233a5
2 parents 91a2b08 + 84c7628
commit da233a5
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
     "name": "tap",
-    "version": "1.0.1",
+    "version": "1.0.2",
     "homepage": "http://pukhalski.github.io/tap.js/",
     "authors": [
         "Ilya Pukhalski <[email protected]>",

diff --git a/dist/tap.js b/dist/tap.js
@@ -71,7 +71,7 @@
 
         move: function( e ) {
             if (!coords['start'] && !coords['move']) return false;
-            
+
             e = utils.getRealEvent( e );
 
             coords.move = [ e.pageX, e.pageY ];
@@ -85,6 +85,15 @@
             e = utils.getRealEvent( e );
 
             if ( coords.offset[ 0 ] < Tap.options.fingerMaxOffset && coords.offset[ 1 ] < Tap.options.fingerMaxOffset && !utils.fireFakeEvent( e, Tap.options.eventName ) ) {
+                if ( window.navigator.msPointerEnabled || window.navigator.pointerEnabled ) {
+                    var preventDefault = function( clickEvent ) {
+                        clickEvent.preventDefault();
+                        e.target.removeEventListener( 'click', preventDefault );
+                    };
+
+                    e.target.addEventListener( 'click', preventDefault, false );
+                }
+
                 e.preventDefault();
             }
 

diff --git a/dist/tap.min.js b/dist/tap.min.js
diff --git a/src/tap.js b/src/tap.js
@@ -20,7 +20,7 @@
 
         move: function( e ) {
             if (!coords['start'] && !coords['move']) return false;
-            
+
             e = utils.getRealEvent( e );
 
             coords.move = [ e.pageX, e.pageY ];
@@ -34,6 +34,15 @@
             e = utils.getRealEvent( e );
 
             if ( coords.offset[ 0 ] < Tap.options.fingerMaxOffset && coords.offset[ 1 ] < Tap.options.fingerMaxOffset && !utils.fireFakeEvent( e, Tap.options.eventName ) ) {
+                if ( window.navigator.msPointerEnabled || window.navigator.pointerEnabled ) {
+                    var preventDefault = function( clickEvent ) {
+                        clickEvent.preventDefault();
+                        e.target.removeEventListener( 'click', preventDefault );
+                    };
+
+                    e.target.addEventListener( 'click', preventDefault, false );
+                }
+
                 e.preventDefault();
             }