-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: customMessageType and MembershipType #230
Conversation
Acceptance Tests step implementation for custom messageType
…sing arise due to change in list of serialized object values indexing differences happened after customtype introduction
fix: files api subscribe event data parsing issue
Added missing parsing information for message Actions response, Fix delete files response giving wrong error information even the call is successfull, Updated change long for last release about breaking change on reconnection policy
… does not need statusCode as per event engine specification
…t emit same status of connected again when a new channel entity is added to subscription
… serialisation can be customisable via user providered pluggable serialisation function
…ching the assert test entities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one not-implemented it LGTM
src/Api/PubnubApi/EventEngine/Subscribe/Effects/EmitMessagesHandler.cs
Outdated
Show resolved
Hide resolved
…d chancel method of EmitMessages effect
…om type payload objects
… trigger `join` event when a subscequent subscription call to same channel by same user is happening due to sequential subscribe test execution within few seconds to prod server
…hat join event will be emitted when a new subscription is created and do not conflict with old execution"s join event within very short time duration
Unit Test implementation update: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pubnub-release-bot release as v7.1.0.0 |
🚀 Release successfully completed 🚀 |
feat: Added support for CustomMessageType in publish, signal, files APIs.
Added support for CustomMessageType in publish, signal, files features.
feat: Added support for Type field in membership APIs.
Added support for Type field in membership APIs.