Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customMessageType and MembershipType #230

Merged
merged 26 commits into from
Dec 4, 2024
Merged

feat: customMessageType and MembershipType #230

merged 26 commits into from
Dec 4, 2024

Conversation

mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Nov 19, 2024

feat: Added support for CustomMessageType in publish, signal, files APIs.

Added support for CustomMessageType in publish, signal, files features.

feat: Added support for Type field in membership APIs.

Added support for Type field in membership APIs.

Acceptance Tests step implementation for custom messageType
mohitpubnub and others added 19 commits November 20, 2024 10:09
…sing arise due to change in list of serialized object values indexing differences happened after customtype introduction
fix: files api subscribe event data parsing issue
Added missing parsing information for message Actions response,
Fix delete files response giving wrong error information even the call is successfull,
Updated change long for last release about breaking change on reconnection policy
… does not need statusCode as per event engine specification
…t emit same status of connected again when a new channel entity is added to subscription
… serialisation can be customisable via user providered pluggable serialisation function
Copy link
Contributor

@jakub-grzesiowski jakub-grzesiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one not-implemented it LGTM

mohitpubnub and others added 5 commits November 30, 2024 08:23
… trigger `join` event when a subscequent subscription call to same channel by same user is happening due to sequential subscribe test execution within few seconds to prod server
…hat join event will be emitted when a new subscription is created and do not conflict with old execution"s join event within very short time duration
@mohitpubnub
Copy link
Contributor Author

mohitpubnub commented Dec 3, 2024

Unit Test implementation update:
For presence event test
Updated channel name to unique random one so that same user won't connect to same channel within small time duration which omits join event to be triggered.

Copy link
Contributor

@jakub-grzesiowski jakub-grzesiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release as v7.1.0.0

@mohitpubnub mohitpubnub merged commit 59ba055 into master Dec 4, 2024
5 checks passed
@mohitpubnub mohitpubnub deleted the CLEN-2336 branch December 4, 2024 13:23
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants