Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return cached and expired packets if we got no response from the network #67

Closed
Nuhvi opened this issue Jul 11, 2024 · 1 comment
Closed

Return cached and expired packets if we got no response from the network #67

Nuhvi opened this issue Jul 11, 2024 · 1 comment
Assignees
@Nuhvi

Comments

@Nuhvi
Copy link
Collaborator

Nuhvi commented Jul 11, 2024

Currently, if we have an expired cached packet, we query the DHT, and if that query returned nothing, we return nothing to the caller of resolve, maybe we should instead return the packet from the cache even if it is expired.
@Nuhvi Nuhvi self-assigned this Jul 11, 2024
Nuhvi added a commit that referenced this issue Oct 8, 2024
@Nuhvi
feat: return expired SignedPacket as fallback, closes #67
4ae72cc
@Nuhvi Nuhvi mentioned this issue Oct 8, 2024
Open
@Nuhvi
Copy link
Collaborator Author

Nuhvi commented Oct 18, 2024

Closing and replacing with #89

@Nuhvi Nuhvi closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nuhvi Nuhvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nuhvi