Make use of Rust 1.63 features #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.60 added the escape_ascii() function on slices of u8. This produces an iterator with items u8 that provides escapement in the style of std::ascii::escape_default(). The returned iterator implements Display, thus we can just pass it directly to write!() to get the resulting escaped string. The above allows to simplify some hand-written version doing the same. Signed-off-by: Uli Schlachter <[email protected]>
Commit 72d70aa added a fallback for older Rust versions that did not yet have cfg(target_has_atomic), which was stabilised in Rust 1.61. Now that our MSRV is above that, we can remove the extra code. Signed-off-by: Uli Schlachter <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
==========================================
- Coverage 12.73% 12.70% -0.03%
==========================================
Files 189 188 -1
Lines 137987 137938 -49
==========================================
- Hits 17572 17528 -44
+ Misses 120415 120410 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eduardosm
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #815 bumped the MSRV, we can clean up some things that were tracked in #538.