Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty lines in xlsx2tabby #110

Open
mslw opened this issue Aug 25, 2023 · 0 comments · May be fixed by #115
Open

Remove empty lines in xlsx2tabby #110

mslw opened this issue Aug 25, 2023 · 0 comments · May be fixed by #115

Comments

@mslw
Copy link
Contributor

mslw commented Aug 25, 2023

I was working with excel files that were sent to me, and noticed in some cases that tabby-many tsv files produced by xlsx2tabby had some empty lines (i.e. delimiters only). In one case it was just two extra lines, but in another a file had 1 048 576 lines while it should have had 4. This later caused load_tabby to hang.

I can share the file privately, but in general I suppose this can happen when formatting has been applied in a particular way in excel / libre office. And FTR, such a file can be sanitized with sed -i '/^\s*$/d' <filename>, so it's not that big of a deal.

Should xlsx2tabby strip such empty lines?

@mslw mslw linked a pull request Nov 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant