Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception on invalid rules #55

Closed
hanneskod opened this issue Jan 16, 2015 · 0 comments · Fixed by #57
Closed

Throw exception on invalid rules #55

hanneskod opened this issue Jan 16, 2015 · 0 comments · Fixed by #57
Assignees
@hanneskod

Comments

@hanneskod
Copy link
Contributor

When reading the proposed documentation in #52 I realised that we could be more helpful to our users by throwing exceptions when they attempt to include or exclude a rule that does not exist. There really is no reason not to throw an exception, and we could probably help find a spelling mistake or two..

Also including and excluding rules should be case insensitive.

I will write a pr for this during the days to come..
@hanneskod hanneskod self-assigned this Jan 16, 2015
@hanneskod hanneskod mentioned this issue Jan 20, 2015
Merged
redbeardcreator added a commit that referenced this issue Jan 23, 2015
@redbeardcreator
Merge pull request #57 from hanneskod/rule-filters
38126d5 
Throw exceptions when unknown rules are white- or blacklisted

Closes #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanneskod hanneskod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw exceptions when unknown rules are white- or blacklisted
1 participant
@hanneskod