Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to TF .12 #49

Open
on4tux opened this issue Mar 20, 2019 · 20 comments
Open

upgrade to TF .12 #49

on4tux opened this issue Mar 20, 2019 · 20 comments

Comments

@on4tux
Copy link

on4tux commented Mar 20, 2019

according to https://www.terraform.io/upgrade-guides/0-12.html#upgrading-terraform-providers, .11 providers need to upgraded to work with TF .12

@GraemeKnights
Copy link

I second this as being very desirable if somebody can manage it please? :)
No idea how much work is involved...

@RobCannon
Copy link

I have converted this to support terraform v0.12. I have one pull request that needs to be merged first, and then a second PR that builds on top of that.

@RobCannon
Copy link

Plus, I have support for using the new VS Code container build technology. You don't have to worry about what version of Go you have installed locally (or you don't even need it installed!). The container defines the development environment. It works pretty well. So, two more PR's waiting once #56 is accepted.

@JackBracken
Copy link
Collaborator

Thanks @RobCannon
Give me a few hours while I catch up to the other issues and PRs and I'll test. :)

@surskitt
Copy link

surskitt commented Jul 5, 2019

Apologies for asking both on here and the pull request, but is this still being considered? Would be really nice to have the provider working with terraform 0.12

@codyja
Copy link

codyja commented Jul 10, 2019

Looking forward to this PR also! Thanks

@zackhorvath
Copy link

Currently in this boat as well - love the plugin!

@pescetto
Copy link

pescetto commented Aug 5, 2019

@RobCannon @prudhvitella You know if that PR is still open? I don't see it in there and I didn't see it being merged. Just hoping to get this provider updated soon. Thanks to all the contributors who've worked on this!

@RobCannon
Copy link

#56 is still open. I have moved onto another company, so i can't really test this module any more. I have the checkins and can submit them as PRs once #56 is committed, but I can't really support them.

@pescetto
Copy link

pescetto commented Aug 9, 2019

@prudhvitella any time frame on this if possible?

@surskitt
Copy link

@RobCannon you mentioned you can't support, would this mean you're not willing and/or able to create a fork and merge both of your pull requests into it?

@RobCannon
Copy link

My code is all here:
https://github.com/RobCannon/terraform-provider-infoblox

There are three branches, one supports modules, one is the update for terraform 0.12 and the third branch adds support for using vscode remote docker support (very handy to make sure all the right requirements are there for building).

@surskitt
Copy link

Thanks a lot @RobCannon . So do I just need to merge them on top of each other?

@RobCannon
Copy link

They are all branched from each other. So the vscoderemote has all of the changes.

@surskitt
Copy link

surskitt commented Sep 2, 2019

@RobCannon I've built from your branches and it all works great! I feel bad for taking so long to thank you.

All the more reason to get these PRs merged.

@ooOOJavaOOoo
Copy link

@prudhvitella any feedback on merging these?

@RobCannon
Copy link

@ooOOJavaOOoo Sorry, I am not familiar "license acceptance error".

@ooOOJavaOOoo
Copy link

@RobCannon sorry, had too many github threads going, getting the nul block error

Error: Provider produced invalid plan

Provider "infoblox" planned an invalid value for
module.infoblox_linux.infoblox_record_host.general[0].ipv6addr: attribute
representing a list of nested blocks must be empty to indicate no blocks, not
null.

Using terraform 0.12.8

@RobCannon
Copy link

Sorry, that it why I can't really support this. I don't have access to an F5 to try to replicate the issue.

Plus, I don't think that issue is a result of my changes. I didn't really make any changes to the core code. It might be due to a change in terraform types, through.

@wenesak
Copy link

wenesak commented Jan 27, 2021

How do you compile this provider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants