-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dtend and floating dates #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the duration/DST issue is sorted.
Actually i belive it is correct; added a test to prove it. Based on this, The end effect of all this is that DST has no effect. The duration of the event is calculated on UTC dates which have no timezone and hence no DST, and they do not end up affecting the output either because the output is returned as local time. |
Btw, reading through jkbrzt#322 and the issue linked from there, there seems to be little chance of getting this merged upstream. DTEND is considered "out of scope" for RRULE. |
3c81454
to
6e1e828
Compare
🛑 This PR should not be merged, see instead |
@simonratner what happened with this PR? As I can see from the rrule opened issue, it says feel free to send a pull request for this to get it included. |
This code is in active use. I'll send a PR. |
6e1e828
to
78b7d01
Compare
See jkbrzt#421. |
PR for local review only; will issue PR to origin repo after.