Skip to content

Commit

Permalink
Cleanup of yml files.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 630138848
  • Loading branch information
protobuf-github-bot authored and copybara-github committed May 3, 2024
1 parent 7b3682f commit 9ad5e0b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/test_cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
required: true
description: "The SHA key for the commit we want to run over"
type: string
is_presubmit:
required: true
description: "When enabled, only run presubmit tests"
type: boolean

permissions:
contents: read
Expand Down Expand Up @@ -365,10 +369,11 @@ jobs:
matrix:
include:
# TODO: investigate and fix
# - name: MacOS CMake
# os: macos-12
# flags: -DCMAKE_CXX_STANDARD=14
# cache-prefix: macos-cmake
- name: MacOS CMake
os: macos-12
flags: -DCMAKE_CXX_STANDARD=14
cache-prefix: macos-cmake
if: ${{ !inputs.is_presubmit }}
- name: Windows CMake
os: windows-2022
flags: >-
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test_runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
# Store the sha for checkout so we can easily use it later. For safe
# events, this will be blank and use the defaults.
checkout-sha: ${{ steps.safe-checkout.outputs.sha }}
is_presubmit: ${{ github.event_name == 'pull_request' || github.event_name == 'pull_request_target' }}
steps:
- name: Check
# Trivially pass for safe PRs, and explicitly error for unsafe ones
Expand Down Expand Up @@ -123,6 +124,7 @@ jobs:
uses: ./.github/workflows/test_cpp.yml
with:
safe-checkout: ${{ needs.check-tag.outputs.checkout-sha }}
is_presubmit: ${{ needs.check-tag.outputs.is_presubmit }}
secrets: inherit

java:
Expand Down
1 change: 1 addition & 0 deletions src/google/protobuf/descriptor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9788,3 +9788,4 @@ Edition InternalFeatureHelper::GetEdition(const FileDescriptor& desc) {
} // namespace google

#include "google/protobuf/port_undef.inc"
// touch file

0 comments on commit 9ad5e0b

Please sign in to comment.