New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ps-select tests for falseish instead of nullish when determining if a input is empty #198

Open

BirMa opened this issue Dec 3, 2021 · 0 comments

Contributor

BirMa commented Dec 3, 2021

If a option in a ps-select is nullish (false or 0), the select label will glitch out.

Could be fixed by replacing || with ?? here:

components/projects/components/select/src/select.component.ts

Line 201 in 3b85f76

const searchText = (this.filterCtrl.value || '').toLowerCase();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment