Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opening a message from a deep-link #56

Open
nesium opened this issue Feb 22, 2024 · 5 comments
Open

Support opening a message from a deep-link #56

nesium opened this issue Feb 22, 2024 · 5 comments
Labels
feature New feature to implement

Comments

@nesium
Copy link
Contributor

nesium commented Feb 22, 2024

As a user I want to send deep-links to my colleagues so that I can point them to selected messages and also do so over different mediums, i.e. via email or bug trackers.

Refs prose-im/prose-pod-system#10

@nesium
Copy link
Contributor Author

nesium commented Feb 22, 2024

@valeriansaliou I was thinking since message deletion/retraction happens via tombstones, could this be a privacy issue if one has a link to a message? Or even if they only scroll through a conversation and watch the traffic since the (tombstomb) message will be loaded.

@nesium
Copy link
Contributor Author

nesium commented Feb 22, 2024

Also what would the UI look like since it dictates the API. Obviously we'd need a method to load a message by ID. Would we need to load messages before and after the selected message as well?

@valeriansaliou
Copy link
Member

On my end, I don't see any issue loading a message from the middle of an archive, and then scrolling backwards or forwards and loading archives in both directions. The messaging view has already support for "forward" scroll loading. Also, loading spinners can show both in forwards and backwards directions.

@valeriansaliou valeriansaliou added the feature New feature to implement label Mar 2, 2024
@nesium
Copy link
Contributor Author

nesium commented Mar 4, 2024

Ok, so I understand that you'd want to display the message in the context of the conversation, basically just scrolled to the message. While it's great that the messaging view already supports foward loading, I do not have any idea at the moment how we'd handle this with MAM. This is a major headache since you'd need to load all messages up until now to have an accurate display of a message, i.e. reactions or edits that were added to a message later. A MAM implementation that would perform the message reducing server-side could fix that problem.

@dscso
Copy link
Contributor

dscso commented Mar 19, 2024

#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature to implement
Projects
None yet
Development

No branches or pull requests

3 participants