Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Open Compute Project log page (when available) to stats gathered on NVMe devices. #223

Open
sbates130272 opened this issue Nov 8, 2024 · 3 comments
Open

Add Open Compute Project log page (when available) to stats gathered on NVMe devices. #223

sbates130272 opened this issue Nov 8, 2024 · 3 comments

Comments

@sbates130272
Copy link

It would be desirable to have the nvme collector(s) gather information from the OCP stats log page as well as from the smart-log page. Note this has been discussed in the nvme-cli project. I am happy to work up a PR for this.

One question I have is if this needs to be done for the python and the shell script? Is the shell script being depreciated?
@dswarbrick
Copy link
Member

Yes, the shell script will be deprecated.

sbates130272 added a commit to sbates130272/node-exporter-textfile-collector-scripts that referenced this issue Nov 15, 2024
@sbates130272
nvme_metrics.py: Add support for a subset of the OCP SMART metrics
18def04 
A subset of all NVMe devices support the OCP SMART metrics which
expands upon the metrics provided by the standard SMART metrics. We
expand the python-based metrics collector to detect if the OCP SMART
metrics are supported and record a subset of them.

Fixes prometheus-community#223.

Signed-off-by: Stephen Bates <[email protected]>
@dswarbrick
Copy link
Member

@sbates130272 You might want to hold off submitting any PR just yet, as it seems we will have to do some non-trivial refactoring of the collector. See #226.

@sbates130272
Copy link
Author

Thanks @dswarbrick. I will keep a track of #226 and see how things play out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dswarbrick @sbates130272