Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Janitorial] Please add MAINTAINERS.md #5026

Open
RichiH opened this issue Nov 27, 2024 · 6 comments · May be fixed by #5083
Open

[Janitorial] Please add MAINTAINERS.md #5026

RichiH opened this issue Nov 27, 2024 · 6 comments · May be fixed by #5083
Labels
enhancement New feature or request

Comments

@RichiH
Copy link
Member

RichiH commented Nov 27, 2024

Is your feature request related to a problem ?

I'm going through all of prometheus-community/ and adding an issue to create a MAINTAINERS.md where it's missing.

Ideally model it on https://github.com/prometheus/prometheus/blob/main/MAINTAINERS.md with a split between general mantainers and subsystem maintainers if applicable.

Thanks,
Richard

Describe the solution you'd like.

.

Describe alternatives you've considered.

.

Additional context.

No response

@RichiH RichiH added the enhancement New feature or request label Nov 27, 2024
@SuperQ
Copy link
Contributor

SuperQ commented Dec 18, 2024

@prometheus-community/helm-charts-maintainers

@jkroepke
Copy link
Member

I guess the CODEOWNERS file needs to be replicated and adjusted as requested.

@GMartinez-Sisti
Copy link
Member

I guess the CODEOWNERS file needs to be replicated and adjusted as requested.

My thought exactly. I also checked https://github.com/prometheus/prometheus/blob/main/.github/CODEOWNERS and it doesn't have half of the maintainers that are on the https://github.com/prometheus/prometheus/blob/main/MAINTAINERS.md file.

These files are bound to be out of sync. Maybe we should automate this to make sure it doesn't happen?

@RichiH
Copy link
Member Author

RichiH commented Dec 18, 2024

There's a lot of people in CODEOWNERS; I don't have enough context if that means "full" maintainer or not.

If it's equivalent, we can also symlink and be done with it.

Autmation and syncing is a good idea, indeed

@jkroepke
Copy link
Member

@RichiH Unlike other community repositories, this is a multi-project repository. It contains multiple distinct projects (i.e., Helm charts) with different responsibilities.

However, there is one exception: there are well-defined admins who are responsible for the entire repository.

My question to you: What is expected? Maintainers for each component or maintainers for the whole repository?

@dotdc dotdc linked a pull request Dec 21, 2024 that will close this issue
1 task
@dotdc
Copy link
Member

dotdc commented Dec 21, 2024

Created #5083
It doesn't add much beyond CODEOWNERS, but it could help maintain consistency with other repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants