Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-snmp-exporter] Extra maintainers #4158

Closed
walker-tom opened this issue Jan 19, 2024 · 5 comments · Fixed by #4224
Closed

[prometheus-snmp-exporter] Extra maintainers #4158

walker-tom opened this issue Jan 19, 2024 · 5 comments · Fixed by #4224
Labels
bug Something isn't working

Comments

@walker-tom
Copy link
Contributor

walker-tom commented Jan 19, 2024

Describe the bug a clear and concise description of what the bug is.

Hello,

The prometheus-snmp-exporter chart is a few versions behind prometheus/snmp_exporter and there are multiple open PRs to update it that haven't been reviewed:

The maintainers are down as @Miouge1 and @xiu according to CODEOWNERS but there are errors for @Miouge1 (suggesting they may not have write access), so it is just @xiu that gets added to PRs.

Are the maintainers open in having any additional maintainers help out? I would be happy to volunteer if so. Thanks!

What's your helm version?

N/A

What's your kubectl version?

N/A

Which chart?

prometheus-snmp-exporter

What's the chart version?

N/A

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

N/A

Anything else we need to know?

No response

@walker-tom walker-tom added the bug Something isn't working label Jan 19, 2024
@walker-tom
Copy link
Contributor Author

@prometheus-community/helm-charts-admins apologies for the direct mention but are you able to help with this at all as mentioned in https://github.com/prometheus-community/helm-charts/blob/main/PROCESSES.md#review-process? Thanks in advance.

@xiu
Copy link
Contributor

xiu commented Feb 4, 2024

@walker-tom Absolutely! I have little time for it at the moment so having more people to help would be great! Can you create a PR adding yourself as a maintainer to the chart?

@SuperQ
Copy link
Contributor

SuperQ commented Feb 14, 2024

I've invited @walker-tom to the @prometheus-community/helm-charts-maintainers team.

@prometheus-community prometheus-community locked and limited conversation to collaborators Feb 14, 2024
@prometheus-community prometheus-community unlocked this conversation Feb 14, 2024
@caarlos0
Copy link
Member

(Lock/unlock was a missclick, sorry)

@onedr0p
Copy link
Contributor

onedr0p commented Feb 15, 2024

Nice to see a maintainer on this, welcome @walker-tom

hint hint nudge nudge #4086 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants