Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-blackbox-exporter] _helpers.tpl produces invalid yaml #4011

Open
cruwe opened this issue Nov 14, 2023 · 2 comments
Open

[prometheus-blackbox-exporter] _helpers.tpl produces invalid yaml #4011

cruwe opened this issue Nov 14, 2023 · 2 comments

Comments

@cruwe
Copy link

cruwe commented Nov 14, 2023

First, thanks for developing these helm-charts and providing them to the community.

When rendering initContainers, the deployment gets templated as in

      initContainers:  - args:
          - -c
          - cat /etc/ssl/certs/ca-certificates.crt /tls/ca.crt > /tls-processed/ca.crt
          command:
          - /bin/bash
      ....

Changing _helpers.tpl to

{{- with .Values.extraInitContainers }}
initContainers:
{{ toYaml . | indent 2 }}
{{- end }}

fixes the problem.

I'd submit a PR, but somehow I fear I am missing the original intent, so I do not want to contribute to any hassle.

Thanks for your consideration.

@zeritti zeritti changed the title _helpers.tpl produces invalid yaml [prometheus-blackbox-exporter] _helpers.tpl produces invalid yaml Nov 14, 2023
@zeritti
Copy link
Member

zeritti commented Nov 14, 2023

Ref. PR #3850

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants