Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-snmp-exporter] migrate to quay.io/prometheus-operator/prometheus-config-reloader #3819

Closed
freedge opened this issue Sep 23, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@freedge
Copy link

freedge commented Sep 23, 2023

Is your feature request related to a problem ?

as in #415,

unlike the other charts that moved to quay.io/prometheus-operator/prometheus-config-reloader, snmp-exporter is still using jimmidyson/configmap-reload

Describe the solution you'd like.

move to quay.io/prometheus-operator/prometheus-config-reloader

Describe alternatives you've considered.

staying with the non official jimmidyson from docker.io

Additional context.

No response

@freedge freedge added the enhancement New feature or request label Sep 23, 2023
@walker-tom
Copy link
Contributor

Thanks for the suggestion, looking at when this was done for the prometheus chart in #3133, it shouldn't be too difficult to change. I'll look to get this changed or feel free to submit a PR for me to review.

@MohammadrezaTavakoli
Copy link
Contributor

Hi @walker-tom,
I created a PR for this issue, please review.
This is my first issue 😄 please tell me if there is something that needs to change.

@walker-tom
Copy link
Contributor

Fixed in #4304, thanks @MohammadrezaTavakoli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants