From ee1ca218a39ff2f682088e8b4d1b2b508d2278fd Mon Sep 17 00:00:00 2001
From: karloramone <karlo.krupljan@gmail.com>
Date: Fri, 10 May 2024 17:21:36 +0200
Subject: [PATCH] [kube-prometheus-stack] fix the retentionSize value

---
 charts/kube-prometheus-stack/Chart.yaml                         | 2 +-
 .../kube-prometheus-stack/templates/prometheus/prometheus.yaml  | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/charts/kube-prometheus-stack/Chart.yaml b/charts/kube-prometheus-stack/Chart.yaml
index 7d28ce75c534..14a4d4165b18 100644
--- a/charts/kube-prometheus-stack/Chart.yaml
+++ b/charts/kube-prometheus-stack/Chart.yaml
@@ -23,7 +23,7 @@ name: kube-prometheus-stack
 sources:
   - https://github.com/prometheus-community/helm-charts
   - https://github.com/prometheus-operator/kube-prometheus
-version: 58.5.0
+version: 58.5.1
 appVersion: v0.73.2
 kubeVersion: ">=1.19.0-0"
 home: https://github.com/prometheus-operator/kube-prometheus
diff --git a/charts/kube-prometheus-stack/templates/prometheus/prometheus.yaml b/charts/kube-prometheus-stack/templates/prometheus/prometheus.yaml
index 93cbd02648dd..67dfe8249749 100644
--- a/charts/kube-prometheus-stack/templates/prometheus/prometheus.yaml
+++ b/charts/kube-prometheus-stack/templates/prometheus/prometheus.yaml
@@ -125,7 +125,9 @@ spec:
 {{ toYaml .Values.prometheus.prometheusSpec.resources | indent 4 }}
 {{- end }}
 {{- if not .Values.prometheus.agentMode }}
+{{- if not .Values.prometheus.prometheusSpec.retentionSize }}
   retention: {{ .Values.prometheus.prometheusSpec.retention | quote  }}
+{{- end }}
 {{- if .Values.prometheus.prometheusSpec.retentionSize }}
   retentionSize: {{ .Values.prometheus.prometheusSpec.retentionSize | quote }}
 {{- end }}