From 261f32877e6f3ae4ee3820c4c343f3f0ea72b28f Mon Sep 17 00:00:00 2001 From: Greg Linklater Date: Mon, 2 Dec 2024 13:02:07 +0100 Subject: [PATCH] Add deployment strategy to helm deployment configs (#10012) --- helm/nessie/templates/deployment.yaml | 2 ++ helm/nessie/values.yaml | 14 ++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/helm/nessie/templates/deployment.yaml b/helm/nessie/templates/deployment.yaml index 5b253290e3e..f9dce9cddcd 100644 --- a/helm/nessie/templates/deployment.yaml +++ b/helm/nessie/templates/deployment.yaml @@ -33,6 +33,8 @@ spec: selector: matchLabels: {{- include "nessie.selectorLabels" . | nindent 6 }} + strategy: + {{- tpl (toYaml .Values.deploymentStrategy) . | nindent 4 }} template: metadata: annotations: diff --git a/helm/nessie/values.yaml b/helm/nessie/values.yaml index bb257a38a4e..88944440c56 100644 --- a/helm/nessie/values.yaml +++ b/helm/nessie/values.yaml @@ -842,6 +842,20 @@ ingress: # - chart-example2.local # secretName: secret1 +# -- Override the strategy for nessie deployment. +# Valid values for type are: RollingUpdate and Recreate. +# If you are using the ROCKSDB version store type then you should use Recreate. +# Max Surge will allow new pods to be created before old ones are culled. Do not enable this when using ROCKSDB +# version store type. +# Max Unavailable will allow old pods to be culled before replacements are created +# See: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy +deploymentStrategy: + {} + # type: RollingUpdate + # rollingUpdate: + # maxUnavailable: 0 + # maxSurge: 1 + # -- Configures the resources requests and limits for nessie pods. # We usually recommend not to specify default resources and to leave this as a conscious # choice for the user. This also increases chances charts run on environments with little