Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors reported by the FPA should be addressed #65

Open
nsoblath opened this issue May 4, 2018 · 1 comment
Open

Errors reported by the FPA should be addressed #65

nsoblath opened this issue May 4, 2018 · 1 comment
Labels

Comments

@nsoblath
Copy link
Member

nsoblath commented May 4, 2018

When the FPA starts up, a bunch of this is typically seen:

ESC[1;31m2018-05-03 20:20:03 [ERROR] _receiver_fpa.cc(246): Exiting due to stream errorESC[0m
ESC[1;31m2018-05-03 21:13:01 [ERROR] _receiver_fpa.cc(246): Exiting due to stream errorESC[0m
ESC[1;31m2018-05-03 22:11:23 [ERROR] _receiver_fpa.cc(246): Exiting due to stream errorESC[0m
ESC[1;31m2018-05-03 22:11:30 [ERROR] _receiver_fpa.cc(246): Exiting due to stream errorESC[0m
ESC[1;31m2018-05-03 22:18:23 [ERROR] _receiver_fpa.cc(246): Exiting due to stream errorESC[0m

And then the errors stop and Psyllid goes on its way in an apparently normal state.

Here's the relevant piece of code from packet_receiver_fpa.cc, starting at line 244:

                        if( ! out_stream< 0 >().set( stream::s_run ) )
                        {
                            LERROR( plog, "Exiting due to stream error" );
                            break;
                        }

There are two problems here:

  1. Since Psyllid is in an apparently normal state after those messages, that indicates that there really isn't an error. Whatever the issue that prevents the FPA from writing to its output stream when it starts up, that should be handled without spitting out a bunch of error messages.
  2. When there is an error message at this point in the code, the FPA should actually exit instead of breaking out of an inner loop and then continuing to run. Unless that is in fact the desired behavior, in which case this should be a warning message.
@nsoblath nsoblath added the bug label May 4, 2018
@nsoblath
Copy link
Member Author

This will be addressed by #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant