Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect RKS size check #103

Open
nsoblath opened this issue Sep 12, 2018 · 0 comments
Open

Incorrect RKS size check #103

nsoblath opened this issue Sep 12, 2018 · 0 comments
Assignees
Labels

Comments

@nsoblath
Copy link
Member

In daq_control::handle_run_command_request(), the minimum size of the RKS is currently 2, when it should be 3.

Lines 802ff

        if( a_request->parsed_rks().size() < 2 )
        {
            return a_reply_pkg.send_reply( dripline::retcode_t::message_error_invalid_key, "RKS is improperly formatted: [queue].run-command.[stream].[node].[command]" );
        }

But, as is noted on line 804, the desired RK is: [queue].run-command.[stream].[node].[command], so it requires at least 3 arguments.

Additional thing to fix: the returned error message contains a mistake: the name of the command is run-daq-cmd, not run-command.

@nsoblath nsoblath added the bug label Sep 12, 2018
@nsoblath nsoblath self-assigned this Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant