Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of save_reactivate #161

Open
wcpettus opened this issue Oct 9, 2018 · 0 comments
Open

Inconsistent use of save_reactivate #161

wcpettus opened this issue Oct 9, 2018 · 0 comments

Comments

@wcpettus
Copy link

wcpettus commented Oct 9, 2018

I think we should be more uniform in our use of psyllid interface's save_reactivate method.

In psyllid_interface currently it is only called once:
https://github.com/project8/dragonfly/blob/develop/dragonfly/implementations/psyllid_provider.py#L330

Its placement is logical method - we expect to call the set_default_config method of roach_daq_run_interface:
https://github.com/project8/dragonfly/blob/develop/dragonfly/implementations/roach_daq_run_interface.py#L521
this in turn has to set a bunch of stuff and then we want the last set (at the end of set_time_window) to do the save_reactivate at the very end.

But none of psyllid interface's other methods call this, whereas most of roach_daq_run_interface's methods do. A more consistent placement would be a save_reactivate call at the end of set_default_config, and no internal calls to the method in psyllid_interface. We should also possibly add warnings to the headers of configure_trigger and configure_time_window in roach_daq_run_interface to indicate they don't complete the configuration by performing the save_reactivate because they are intended as intermediate methods.

Or I welcome other thoughts, @laroque and @cclaessens.

Motivation: this really surprised me today and took me a bit to track down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant