Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more readable slack messages #140

Open
laroque opened this issue Mar 28, 2018 · 1 comment
Open

more readable slack messages #140

laroque opened this issue Mar 28, 2018 · 1 comment
Labels
enhancement low priority things we may never get to

Comments

@laroque
Copy link
Member

laroque commented Mar 28, 2018

It would be awesome if we could format messages sent to slack. in particular, I'm thinking separating the error message from the traceback (the latter in either a code block ` or in a quote block >>>)... That sounds hard since the receiver is just grabbing a string from a message payload, we'd probably have to rework the alert message payloads (keeping in mind that we want those to be more generic so that they are usable for other notification systems like twitter/sms/email/etc.). Depending on that thought, this may require a dripline use protocol change.

Super low priority, but something to maybe think about if someone earns themself a diversion project.

@laroque laroque added enhancement low priority things we may never get to labels Mar 28, 2018
@wcpettus
Copy link

wcpettus commented Apr 7, 2018

By my count, we dump the traceback on Slack in 4 places:

  • in dragonfly:open_spimescape_portal, ln 77
  • in dripline:service when a service is crashing, ln 435
  • in dripline:endpoint when a handle_request fails, ln 197
  • in dripline:scheduler when a process_schedule fails, ln 180

The traceback exists in the code in several other places, but is left at info or debug level

I would propose de-escalating all of the above cases to logger.info; there is already an associated message saying the brief error going to slack. The traceback is demonstrably ill-suited to slack, and the error messages should be sufficiently descriptive to give a sense of the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement low priority things we may never get to
Projects
None yet
Development

No branches or pull requests

2 participants