Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cached dir content changed message should print out *what* changed #159

Open
tych0 opened this issue Apr 21, 2021 · 2 comments
Open

cached dir content changed message should print out *what* changed #159

tych0 opened this issue Apr 21, 2021 · 2 comments

Comments

@tych0
Copy link
Collaborator

tych0 commented Apr 21, 2021

https://github.com/anuvu/stacker/blob/master/cache.go#L260

we have the diff here, we could iterate through it and print all the paths that changed. but there are potentially lots of these, so we should do some reasonable truncating.

@raharper
Copy link
Contributor

Yeah, it could get verbose real quick. I would suggest:

  1. if --debug is set, print the whole lot
  2. if not --debug then we could print which import entry was modified and mention passing --debug for complete details.

@tych0
Copy link
Collaborator Author

tych0 commented Apr 21, 2021

I think it might be reasonable to print maybe the first 1-2 with a (N additional differences) or something, just to jog peoples' memory. But yeah, I agree that --debug should print everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants