This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Complete SHA-256 circuit tests #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it after passing block to padder
blaxill
approved these changes
Aug 19, 2021
| (**** list boolean equality decider ****) | ||
|
|
||
| (* TODO: this may be upstreamed, remove if | ||
| https://github.com/mit-plv/coqutil/pull/37 gets merged *) |
There was a problem hiding this comment.
the "gets merged" has happened, happy recompiling 😉
There was a problem hiding this comment.
Thanks! On it 🙂
| : list (list N) := | ||
| let digests := List.map (fun '(done, (digest, accept_input)) => digest) out in | ||
| (* remove repetitions of the same digest *) | ||
| dedup (list_eqb N.eqb) digests. |
There was a problem hiding this comment.
Could it be possible to get the same digest twice, which would make this code wrong? I'd estimate that the probability of this is roughly in the same order of magnitude as the probability of finding hash collisions, ie in the range of don't care, but my formal correctness mindset just couldn't refrain from commenting here... 😉
There was a problem hiding this comment.
Yes, my formal correctness brain also considered this but decided it was probably not likely enough to work around!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #880
All SHA-256 tests, including the ones that test intermediate digests and only-padding, are now run on the cava2 SHA-256 implementation. I removed the "sanity check", since it's a bit annoying to update when something about the signalling changes and is now superseded by the tests file.
Part of the code here is a boolean list equality decider that I've submitted upstream to coqutil (see mit-plv/coqutil#37), so hopefully that will get merged and the code will no longer live in our test file.