Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download tar of compiled nginx binaries rather than use package #12

Open
stuart-warren opened this issue Sep 11, 2014 · 1 comment
Open

Comments

@stuart-warren
Copy link

Hi,

All other buildpacks I've seen follow 12factor principles and "vendor" any required dependencies into the app directory. Take an Apache buildpack for example https://github.com/Kloadut/heroku-buildpack-static-apache/blob/master/bin/compile

The package approach causes issues with other PaaS like Deis who use a separate runner container to the builder which only has the contents of the builddir. see: deis/deis#1796

@stuart-warren
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant