Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appimagetool is deploys libX11-xcb.so.1 which is on the exclude list #305

Open
Samueru-sama opened this issue Sep 15, 2024 · 2 comments
Open

Comments

@Samueru-sama
Copy link

I was doing some tests with thunar and I discovered this:

image

libX11-xcb.so.1 gets deployed even though it is on the exclude list.

The reason is likely because it is not on the internal list that go-appimage uses that hasn't been updated in 5 years?

@probonopd
Copy link
Owner

I think genexclude.go is supposed to update that list; possibly we are not running it (properly) when building go-appimage?
We should make it so that it runs whenever the GitHub Actions job runs, and possible delete the static file.
We should not have such lists in multiple places.
PR would be appreciated.

@probonopd
Copy link
Owner

probonopd commented Nov 3, 2024

This being said, I use -s deploy most of the time anyways, in which case the excludelist is not used at all. (For lean AppImages, best build the ingredients on Alpine Linux with musl libc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants