-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appimaged broken, likely by #115 #121
Comments
This seems to be a problem with my squashfs library, specifically when closing after reading from it. In theory the closing isn't necessary, as it's just so that up to ~2MB of data isn't held in memory forever, but in theory go's garbage collector should do a decent job taking care of that. |
Doing a quick profile when extracting the firefox appimage, it doesn't seem like there's any reasy to keep the close function. I'll release a new version and submit a new PR to make appimaged use the newer version. |
If you have any possbility to do so, then please test the appimaged AppImage before sending the PR. Thank you very much! |
I'll test it, but the issue was fairly random. I ran into this issue a while ago, and thought I had solved it, but apparently not. Shouldn't happen now though, because I just removed that bit of code, lol. |
Hello @CalebQ42, thanks for your PR #115 which I had merged. Did you try the resulting appimaged AppImage on a Ubuntu Live ISO?
Looks like there is something going wrong badly:
The text was updated successfully, but these errors were encountered: