-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for skrub's TableReport #810
Conversation
Coverage Report for ./skore-ui
File Coverage
|
I like the fact that we have this feature in a basic form, allowing the user to track table reports. This also promotes skrub in our documentation. Can we hack the font so it looks better? |
thanks for adding this! indeed that's very nice for skrub :)
|
also I've noticed that adding a report makes the ui very slow and I suppose that is a problem in the tablereport itself rather than on the skore side |
Hi @jeromedockes thanks for your comments. Could you share the snippet you used to populate that report ? |
from skore.project import create, load
from skrub import TableReport, datasets
create(project_name="project.skore")
s = load("project.skore")
df = datasets.fetch_employee_salaries().X
report = TableReport(df)
s.put("table report", report) |
There is indeed a small freeze when the report is rendering. Especially when switching to the distribution tab. |
I was wondering, don't we want to store the raw data used to present the report? |
As sklearn model viewer skrubs generates unique ids for dom elements. This is a bit painful for use as it triggers a render of the widget at each polling. So like for sklearn models I chose to store the rendered data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about changing the class to a "namespace"?
Co-authored-by: Thomas S. <[email protected]>
I was a bit to fast to accept using inheritance. HTML as never been treated as a media, it was a primitive type with @thomass-dev & @augustebaum I'll let you decide how to manage html and let me know how to fix this. |
This PR adds a
SkrubTableReportItem
.Usage:
UI preview:
Limitation sounds like there is no dark mode for now.