fix(docs): Add screenshot of cross-validation plot #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarieS-WiMLDS
requested changes
Oct 29, 2024
augustebaum
force-pushed
the
594-docs-in-the-skore-cross-validation-example-the-plotly-graph-is-not-full-size-in-the-rendering
branch
from
329bb52
to
b48f907
Compare
MarieS-WiMLDS
approved these changes
Oct 29, 2024
augustebaum
force-pushed
the
594-docs-in-the-skore-cross-validation-example-the-plotly-graph-is-not-full-size-in-the-rendering
branch
from
f918ee9
to
834b724
Compare
This is a quick fix to address #594. In the end, I took a screenshot manually (by using the "Download plot as png" button of the Plotly widget) and displayed it with matplotlib. Here are all the alternatives I considered, and what didn't work with them: - Use SVG instead of PNG - For that, I'd need to use Plotly's `fig.write_image`, and the library that Plotly uses for this, Kaleido, is currently broken: plotly/Kaleido#210 - Export plotly figure to a file during the example and read it - For that I also need Plotly's `fig.write_image` - Use Pillow for displaying, instead of matplotlib (which is not really made for that) - Only matplotlib is supported by sphinx-gallery, the library that renders the examples
augustebaum
force-pushed
the
594-docs-in-the-skore-cross-validation-example-the-plotly-graph-is-not-full-size-in-the-rendering
branch
from
834b724
to
e170737
Compare
augustebaum
deleted the
594-docs-in-the-skore-cross-validation-example-the-plotly-graph-is-not-full-size-in-the-rendering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to address #594.
In the end, I took a screenshot manually (by using the "Download plot as png" button of the Plotly widget) and displayed it with matplotlib.
Here are all the alternatives I considered, and what didn't work with them:
fig.write_image, and the library that Plotly uses for this, Kaleido, is currently broken:plotly.write_imagefails to find Kaleido executable plotly/Kaleido#210fig.write_image