Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skore.cross_validate should support matplotlib, altair (and plotly) #651

Closed
sylvaincom opened this issue Oct 31, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@sylvaincom
Copy link
Contributor

sylvaincom commented Oct 31, 2024

This is priority P2.

Problem

skore's cross_validate displays the results using plotly.

But there are issues with plotly. We found that plotly does not render well in the Sphinx documentation (#594) so we opened issues to plotly and to sphinx. Indeed, this plotly rendering issue appears also in the official Sphinx doc.

Related: plotly/Kaleido#209

Nevertheless, while @augustebaum first started using altair, with @MarieS-WiMLDS we recommended a switch from altair to plotly as we believe data scientists in the industry are more familiar with plotly. @koaning prefers altair over plotly. Note that, apparently, the plotly rendering issue on Sphinx also applies to altair.

Suggestion

Let's support both plotly and altair (and matplotlib) and have plot_backend argument for the users to specify which one they prefer?

Something like:

from skore import cross_validate
...
cv_results = cross_validate(Ridge(), X, y, cv=5, project=my_project, plot_backend="altair")

Example: pandas has a plot method that does matplotlib by default but you can also have plotly:
https://plotly.com/python/pandas-backend/

@sylvaincom sylvaincom added the enhancement New feature or request label Oct 31, 2024
@tuscland
Copy link
Member

tuscland commented Nov 6, 2024

It is difficult to support several backends for every assistive feature.
If the problem is cosmetic, users can however access the underlying data and draw their own plot using the library of their choice.

@tuscland tuscland closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants