Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In pyproject.toml, define each requirement using range of versions #404

Open
thomass-dev opened this issue Sep 27, 2024 · 3 comments · May be fixed by #490
Open

In pyproject.toml, define each requirement using range of versions #404

thomass-dev opened this issue Sep 27, 2024 · 3 comments · May be fixed by #490
Assignees
@thomass-dev
Labels
chore Internal enhancement work to be done

Comments

@thomass-dev
Copy link
Collaborator

thomass-dev commented Sep 27, 2024 •
edited
Loading

Actually, user can install skore without restrictions on the skore's dependencies.
It means that user can use old (and incompatible) version of one of dependencies.
With an incompatible dependency version, some errors can occur obscurely to the user only at the runtime.

We can't be compatible with all of versions of all package.
The convention is to define a range of version between two majors release.
@thomass-dev thomass-dev mentioned this issue Sep 27, 2024
Open
@tuscland tuscland added the chore Internal enhancement work to be done label Oct 1, 2024
@augustebaum
Copy link
Contributor

Would it be acceptable to perform a pip freeze on my machine and use the versions I have as lower bounds?

augustebaum added a commit that referenced this issue Oct 14, 2024
@augustebaum
chore(python deps): Set lower bounds for python dependencies
4db7ac2 
Closes #404
@augustebaum augustebaum linked a pull request Oct 14, 2024 that will close this issue
Draft
@thomass-dev
Copy link
Collaborator Author

I don't know if its enough.
We don't want to be restrictive, so we need to test the lowest versions we can accept on each dependencies.

@augustebaum augustebaum self-assigned this Oct 14, 2024
@tuscland tuscland assigned thomass-dev and unassigned augustebaum Oct 18, 2024
@tuscland
Copy link
Member

Assigned to @thomass-dev so he can bring the issue forward.

augustebaum added a commit that referenced this issue Oct 28, 2024
@augustebaum
chore(python deps): Set lower bounds for python dependencies
b3794a7 
Closes #404
augustebaum added a commit that referenced this issue Oct 28, 2024
@augustebaum
chore(python deps): Set lower bounds for python dependencies
fef96b1 
Closes #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomass-dev thomass-dev

Labels
chore Internal enhancement work to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(python deps): Set lower bounds for python dependencies probabl-ai/skore
3 participants
@tuscland @thomass-dev @augustebaum