The validity period of the retry token and NEW_TOKEN

[cyberspace61]

https://github.com/private-octopus/picoquic/blob/c0f0313de4b8c35ea4f3193913674361a8b32692/picoquic/packet.c#L1277C1-L1281C6

Hello, I would like to ask why, when generating the retry token and NEW_TOKEN, the offsets PICOQUIC_TOKEN_DELAY_SHORT and PICOQUIC_TOKEN_DELAY_LONG are added in the calculation of the token validity period? This makes it seem that the validity period of the retry token is 2 minutes and 4 seconds, and the NEW_TOKEN is valid for 48 hours. However, in practical applications, wouldn't it be more appropriate to set the retry token's validity period to 4 seconds and the NEW_TOKEN's validity period to 24 hours?
Thank you very much for your help!

[huitema]

Good catch. This looks like a bug.

The clean solution would be to rework the picoquic_prepare_retry_token API. It currently takes a "current time" parameter, it should also take a "desired duration" parameter. That "desired duration" should be set to either the SHORT or LONG constant in the calls, and we should not add another value in the function.