Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: use soldeer for solidity dependencies #25

Open
sripwoud opened this issue Jul 3, 2024 · 3 comments
Open

dx: use soldeer for solidity dependencies #25

sripwoud opened this issue Jul 3, 2024 · 3 comments
Labels
dependencies 📦 Improvements or additions to documentation dx 🔧 Developer experience

Comments

@sripwoud
Copy link
Member

sripwoud commented Jul 3, 2024

https://soldeer.xyz/
Related: semaphore-protocol/semaphore#800

@sripwoud
Copy link
Member Author

sripwoud commented Jul 4, 2024

Migration to soldeer readiness check:
We can migrate our packages to soldeer if all their dependencies are also available on soldeer
It would make the conf more complex and clunky to have a mix of deps coming from gitmodules (forge), node_modules (hardhat) and soldeer. So ideally everything would be downloaded from and uploaded to soldeer.

pkg dep available on https://soldeer.xyz/ request to publish to soldeer
excubiae eas-contracts ethereum-attestation-service/eas-contracts#146
excubiae openzeppelin/contracts yes NA
excubiae semaphore-protcol/contracts semaphore-protocol/semaphore#800
lean-imt poseidon-solidity yes NA
imt poseidon-solidity yes NA
lazy-imt poseidon-solidity yes NA
lazy-tower poseidon-solidity yes NA

@cedoor cedoor added the dependencies 📦 Improvements or additions to documentation label Jul 4, 2024
@cedoor cedoor added this to ZK-Kit Jul 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Jul 4, 2024
@cedoor cedoor moved this from 📋 Backlog to ♻️ Grooming in ZK-Kit Jul 4, 2024
@cedoor
Copy link
Member

cedoor commented Jul 4, 2024

@sripwoud thanks very much for that table!

I didn't know poseidon-solidity was on Soldeer. @vimwitch did you publish it?

@sripwoud
Copy link
Member Author

sripwoud commented Jul 4, 2024

Err no that was me 😅 (i wanted to test soldeer quickly), but I link to your repo @vimwitch
You could take over my soldeer account if you want (but the UI does not seem to have a feature to update the email address yet....)

@cedoor cedoor added the dx 🔧 Developer experience label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Improvements or additions to documentation dx 🔧 Developer experience
Projects
Status: ♻️ Grooming
Development

No branches or pull requests

2 participants