Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of FHI-aims interface to CASM #137

Open
wants to merge 48 commits into
base: 0.3.X
Choose a base branch
from

Conversation

janklinux
Copy link

Still needs functional testing which I am on right now, for now:

  1. The user HAS TO define the DFT code in the relax.json of other than vasp
  2. casm setup works for FHI-aims
  3. There has been some redefinition and reorganization of internals read / write of the settings i.e.
  4. Some streamlining of code could be done with respect to common routines and code-specific interfaces
  5. For FHI-aims there is new functionality in terms of surface definitions and relaxation settings that can fix specific parts of the slab
  6. I cleaned up the code to PEP8 in the files I made changes to
  7. I strongly recommend using at least PEP8 standards to maintain python code readability

Jan Kloppenburg and others added 30 commits January 23, 2019 10:55
	new file:   python/casm/casm/aims/aims.py
	new file:   python/casm/casm/aims/io/__init__.py
	new file:   python/casm/casm/aims/io/aimsrun.py
	new file:   python/casm/casm/aims/io/basis.py
	new file:   python/casm/casm/aims/io/control.py
	new file:   python/casm/casm/aims/io/geometry.py
	new file:   python/casm/casm/aims/io/io.py
	new file:   python/casm/casm/aims/io/kpoints.py
	new file:   python/casm/casm/aims/io/parser.py
	new file:   python/casm/casm/aims/io/steps.py
	new file:   python/casm/casm/aims/relax.py
	new file:   python/casm/casm/aimswrapper/__init__.py
	new file:   python/casm/casm/aimswrapper/aimswrapper.py
	new file:   python/casm/casm/aimswrapper/relax.py
	modified:   python/casm/casm/scripts/casm_calc.py
	modified:   python/casm/casm/project/io.py
	modified:   python/casm/casm/wrapper/misc.py
	modified:   python/casm/casm/aimswrapper/relax.py
	modified:   python/casm/casm/vasp/io/poscar.py
Conflicts:
	python/casm/casm/aims/io/geometry.py

	modified:   python/casm/casm/aims/aims.py
	modified:   python/casm/casm/aims/io/geometry.py
	modified:   python/casm/casm/aimswrapper/aimswrapper.py
	modified:   python/casm/casm/aimswrapper/relax.py
	modified:   python/casm/casm/project/io.py
	modified:   python/casm/casm/wrapper/misc.py
	modified:   python/casm/casm/aims/io/geometry.py
	modified:   python/casm/casm/aims/io/io.py
	modified:   python/casm/casm/project/io.py
	new file:   python/casm/casm/scripts/casm_bands.py
	modified:   python/casm/casm/scripts/casm_calc.py
	new file:   python/casm/casm/vasp/bands.py
	modified:   python/casm/casm/vaspwrapper/__init__.py
	modified:   python/casm/casm/vaspwrapper/converge.py
	modified:   python/casm/casm/vaspwrapper/relax.py
	modified:   python/casm/casm/vaspwrapper/vaspwrapper.py
	modified:   python/casm/requirements.txt
	modified:   python/casm/setup.py
	modified:   python/casm/casm/project/io.py
	modified:   python/casm/casm/vasp/bands.py
Conflicts:
	python/casm/casm/scripts/casm_calc.py
	modified:   python/casm/casm/wrapper/misc.py
	modified:   python/casm/casm/scripts/casm_bands.py
	modified:   python/casm/casm/vasp/bands.py
	modified:   python/casm/casm/vasp/io/incar.py
	modified:   python/casm/casm/vasp/relax.py
	modified:   python/casm/casm/vaspwrapper/relax.py
	modified:   python/casm/casm/scripts/casm_bands.py
	modified:   python/casm/casm/vasp/bands.py
	modified:   python/casm/casm/scripts/casm_bands.py
	modified:   python/casm/casm/vasp/bands.py
	modified:   python/casm/casm/project/io.py
	modified:   python/casm/casm/project/io.py
	new file:   python/casm/casm/scripts/casm_feff.py
	modified:   python/casm/setup.py
	modified:   python/casm/casm/project/io.py
	modified:   python/casm/casm/scripts/casm_feff.py
	modified:   python/casm/casm/project/io.py
	modified:   python/casm/casm/project/io.py
	modified:   python/casm/casm/scripts/casm_feff.py
	modified:   python/casm/casm/feff/feff.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant