Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Insert logs failed item moving in #6

Open
Rothes opened this issue Feb 5, 2022 · 1 comment · May be fixed by #72
Open

[BUG] Insert logs failed item moving in #6

Rothes opened this issue Feb 5, 2022 · 1 comment · May be fixed by #72
Labels
bug Something isn't working v3

Comments

@Rothes
Copy link
Contributor

Rothes commented Feb 5, 2022

Describe the bug
E.g. When opening a furnace, Shift + Click a pickaxe in your inventory, the pickaxe is not put in the furnace, but Prism still logs it.

To Reproduce
Steps to reproduce the behavior:

  1. Open a furnace.
  2. Shift + Click a pickaxe or sth else in your inventory.
  3. Inspect the furnace.

Expected behavior
Not to log it.

Screenshots
N/A

Server (please complete the following information):

  • Prism Version: 3.0.3
  • Server Type: JettPack (Fork of Paper)
  • Server Version: 1.18.1
@Rothes Rothes changed the title [BUG] Insert logs failed item move in [BUG] Insert logs failed item moving in Feb 5, 2022
@viveleroi viveleroi added bug Something isn't working v3 labels Apr 25, 2022
@Rothes
Copy link
Contributor Author

Rothes commented May 22, 2022 •
edited
Loading

Investigated a little. For Hopper inserting to BrewingStand and Furnace, we are using InventoryMoveItemEvent. Javadocs say it

Called when some entity or block (e.g. hopper) tries to move items directly from one inventory to another.

So it may be fail. Schedule a task next tick, check the ItemStack's hash should fix it.

@Rothes Rothes linked a pull request Dec 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NMS to check inventory moves are proceeded; Get Item by clicking message Rothes/PrismRefracted
2 participants
@viveleroi @Rothes