Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] java.lang.StackOverflowError: null in utils.block.Utilities.findConnectedBlocksOfType #38

Open
viveleroi opened this issue Jun 9, 2022 · 3 comments · May be fixed by #51
Open

[BUG] java.lang.StackOverflowError: null in utils.block.Utilities.findConnectedBlocksOfType #38

viveleroi opened this issue Jun 9, 2022 · 3 comments · May be fixed by #51
Labels
bug Something isn't working v3

Comments

@viveleroi
Copy link
Contributor 

[12:50:44] [Server thread/ERROR]: Could not pass event BlockBreakEvent to Prism v3.0.3
java.lang.StackOverflowError: null
	at net.minecraft.world.level.Level.getChunk(Level.java:636) ~[?:?]
	at net.minecraft.world.level.Level.getBlockState(Level.java:975) ~[?:?]
	at org.bukkit.craftbukkit.v1_18_R2.block.CraftBlock.getType(CraftBlock.java:227) ~[purpur-1.18.2.jar:git-Purpur-1628]
	at network.darkhelmet.prism.utils.block.Utilities.findConnectedBlocksOfType(Utilities.java:605) ~[Prism-3.0.3-all.jar:?]
	at network.darkhelmet.prism.utils.block.Utilities.findConnectedBlocksOfType(Utilities.java:607) ~[Prism-3.0.3-all.jar:?]
	at network.darkhelmet.prism.utils.block.Utilities.findConnectedBlocksOfType(Utilities.java:607) ~[Prism-3.0.3-all.jar:?]
	at network.darkhelmet.prism.utils.block.Utilities.findConnectedBlocksOfType(Utilities.java:607) ~[Prism-3.0.3-all.jar:?]
	at network.darkhelmet.prism.utils.block.Utilities.findConnectedBlocksOfType(Utilities.java:607) ~[Prism-3.0.3-all.jar:?]
	at network.darkhelmet.prism.utils.block.Utilities.findConnectedBlocksOfType(Utilities.java:607) ~[Prism-3.0.3-all.jar:?]
@viveleroi viveleroi added bug Something isn't working v3 labels Jun 9, 2022
@Rothes
Copy link
Contributor

Rothes commented Jun 10, 2022 •
edited
Loading

I received this bug report once a time (from other users). But I ignored it because no extra info.
Maybe capture the Exception for more debug info.

@viveleroi
Copy link
Contributor Author

I have no extra info, just noticed it in the logs. The ore alert stuff needs an overhaul anyway. For v4 I was planning to make it a separate plugin. For example it was never designed to work with large veins, it caps at 100 blocks and often re-alerts because the vein was too large.

@TauCubed
Copy link

I wrote some code to specifically do this with one of my plugins (including corner blocks) I'll pop in a pr later today.

TauCubed added a commit to TauCubed/PrismRefracted that referenced this issue Dec 15, 2022
@TauCubed
use non-stack-overflowy method of finding connected blocks
7ff435f 
if we only need one portal don't bother checking for more.

Closes prism#38 : resolved
@TauCubed TauCubed linked a pull request Dec 17, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pr fix connected blocks, nether portal break double logging TauCubed/PrismRefracted
3 participants
@viveleroi @TauCubed @Rothes