Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable naming may be ambigous #4

Open
jbuisine opened this issue May 1, 2021 · 0 comments
Open

Variable naming may be ambigous #4

jbuisine opened this issue May 1, 2021 · 0 comments
Labels
invalid This doesn't seem right

Comments

@jbuisine
Copy link
Member

jbuisine commented May 1, 2021

In code function : https://github.com/prise-3d/rawls_api/blob/devel/api.py#L16-L31, CSV_file variable has Class naming convention and can bring ambiguity.

It's better to always use same naming convention for variable and Classes:

class CSVFile():
    pass
class MyClass():
    pass

instance = MyClass()
csv_file_instance = CSVFile()
@jbuisine jbuisine added the invalid This doesn't seem right label May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant