Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

[bug] Approval, Request Change, Approve produces incorrect counting of valid approvals #8

Closed
prince-chrismc opened this issue Feb 22, 2021 · 0 comments

Comments

@prince-chrismc
Copy link
Owner

prince-chrismc commented Feb 22, 2021

Seems like this code is not working 🤔

if !new { // Duplicate review (usually an accident)
break


Update:

Seems to be a consequence of #4, by maintaining a unique list of blockers/approvers we need to decrement the counter when approvals are disregarded

summary.HeadCommitApprovals = removeUnique(summary.HeadCommitApprovals, reviewerName)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant