Ready To merge section

[ericLemanissier]

That's a very nice addition, but you should count only approved reviewers (listed in conan-io/conan-center-index#2857 (comment)), otherwise prs like conan-io/conan-center-index#4079 are marked as ready to merge, whereas they are still missing some reviews.

EDIT: also, could you add a column giving the status of the PR (success./failure/pending) ?

[prince-chrismc]

Thank for for the issue ❤️ I saw it last night but I didn't see an obvious solution

I was thinking a JSON list which would be easy. Any Ideas?

[ericLemanissier]

I was thinking dumb full text search in conan-io/conan-center-index#2857 (comment)

[prince-chrismc]

Hmmm there have been a few failures post code review changes, it's worth noting 🤔

Out of curiosity how does it impact your decision to review?

[ericLemanissier]

I won't take a look to any PR which already has sufficient reviews (except cases were I have a direct interest in the package). It saves both my time, and also useless notifications to everybody else. I have the same reasoning for PR with a failed status

[prince-chrismc]

I find the stability unreliable, if there's a fail there's usually a label and I filter on that... however the case were CI is stuck might be interesting

[ericLemanissier]

Ok, I did not know you filtered on labels. The only missing case is if the contributor did not request access on conan-io/conan-center-index#4 (which makes conan-io/conan-center-index#3724 ready to be merged)

[prince-chrismc]

No the "No beta" label was removed... its the CI that's failed and no one has restarted hence #6 (comment) above

[prince-chrismc]

https://docs.github.com/en/free-pro-team@latest/rest/reference/repos#statuses

Supposedly support by underlying library

UPDATE:

https://api.github.com/repos/conan-io/conan-center-index/commits/78db84765bc6de1a254d969c4d6b2f09a9862355/status

"state": "success",
  "statuses": [
    {
      "url": "https://api.github.com/repos/conan-io/conan-center-index/statuses/78db84765bc6de1a254d969c4d6b2f09a9862355",
      "avatar_url": "https://avatars1.githubusercontent.com/u/54393557?v=4",
      "id": 11793781799,
      "node_id": "MDEzOlN0YXR1c0NvbnRleHQxMTc5Mzc4MTc5OQ==",
      "state": "success",
      "description": "This commit looks good",
      "target_url": "https://ci-conan-prod.jfrog.team/job/cci/job/master/3097/display/redirect",
      "context": "continuous-integration/jenkins/branch",
      "created_at": "2021-01-07T16:08:48Z",
      "updated_at": "2021-01-07T16:08:48Z"
    }
  ],
  "sha": "78db84765bc6de1a254d969c4d6b2f09a9862355",
  "total_count": 1,

[prince-chrismc]

Found it!

https://api.github.com/repos/conan-io/conan-center-index/statuses/15ccdabe9b96b52ab42e419eb9e2ce62c6c3bf62?per_page=1

[prince-chrismc]

Yay or nay?

[ericLemanissier]

thank you, it's perfect !