Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayableGraph was not destroyed. #89

Open
xtc06 opened this issue Jun 1, 2023 · 13 comments
Open

PlayableGraph was not destroyed. #89

xtc06 opened this issue Jun 1, 2023 · 13 comments
Labels
bug Something isn't working

Comments

@xtc06
Copy link

xtc06 commented Jun 1, 2023

Hi,

Hello, I wrote some code to export, it works very well, but I have the message :
PlayableGraph was not destroyed.
My code :
ExportOptions exportOptions = new ExportOptions(); exportOptions.MergeClipsWithMatchingNames = true; GLTFSceneExporter exporter = new GLTFSceneExporter(gameObject.transform, exportOptions); exporter.SaveGLB(path, fileName);

I can't use using, destroy or dispose for GLTFSceneExporter, am I doing something wrong?

@hybridherbst
Copy link

hybridherbst commented Jun 1, 2023

Hey, which version/commit are you on? There's a version/2.x branch with more improvements by now, so would be great if you could test on that and ideally also on latest 1.x, 1f5c1a2.

That message would mean that something in your export is using humanoid rigs, which is supported, but there were some versions where it produced an error similar to what you've posted.

@hybridherbst hybridherbst added the help wanted Extra attention is needed label Jun 1, 2023
@xtc06
Copy link
Author

xtc06 commented Jun 1, 2023

I added the package from this URL :
https://github.com/prefrontalcortex/UnityGLTF.git?path=/UnityGLTF/Assets/UnityGLTF
The version : 1.24.0-pre.2

@hybridherbst
Copy link

hybridherbst commented Jun 1, 2023

Can you try either
https://github.com/prefrontalcortex/UnityGLTF.git?path=/UnityGLTF/Assets/UnityGLTF#release/2.0.3-exp
or
https://github.com/prefrontalcortex/UnityGLTF.git?path=/UnityGLTF/Assets/UnityGLTF#release/1.24.2-pre?

@xtc06
Copy link
Author

xtc06 commented Jun 1, 2023

Thanks I will try :)

@xtc06
Copy link
Author

xtc06 commented Jun 2, 2023

I will test when the repository will be accessible again ^^

@hybridherbst
Copy link

Sorry, typo! I meant from the prefrontal cortex fork, I updated the URLs above

@xtc06
Copy link
Author

xtc06 commented Jun 2, 2023

I just tested the 2.0.3-exp, the problem persists.

@hybridherbst
Copy link

Thank you - then it would be great if you could send me a zipped project (without Library folder etc.) where the error reproduces when exporting a file and some steps. Thanks!

@xtc06
Copy link
Author

xtc06 commented Jun 4, 2023

Yes as soon as I have time I will prepare a file for you.
I tested (the 2.0.3-exp) on another scene, with a new script and a new FBX to export, the problem no longer seems to be present, the scene that is causing me problems contains a fbx rigger, content elements in the bones when they are dissable, create error logs during the export, and the meshes have an UNorm8 color format which also poses a problem during the export, I wonder if the problem does not come from that :)

@hybridherbst
Copy link

Thanks for the additional info - yes, the issue is most likely from some Animation Rigging combination, that's pretty much the only case where a playable graph is directly sampled on export. So a repro file would be well appreciated!

And if you can open another issue about the UNorm8 issues that would be appreciated too!

@xtc06
Copy link
Author

xtc06 commented Jun 4, 2023

Yes the problem comes from the animations.
I'm on unity 2021.3.22f1 URP.

PlayableGraph.zip

@hybridherbst
Copy link

Hey @xtc06 I was finally able to look at your report, however there's not a complete file in the zip - the model is missing bones, so I can't reproduce your issue. Would be great if you could export as .unitypackage so I can reproduce here. Thanks!

@hybridherbst hybridherbst added bug Something isn't working and removed help wanted Extra attention is needed labels Jul 17, 2023
@xtc06
Copy link
Author

xtc06 commented Jul 17, 2023

I will do what is necessary when I have a little more time available, unfortunately I have a lot of work at the moment, but I promise to do it as soon as possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants